Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Vue] migrate manage gdpr directive to Vue #19002

Merged
merged 14 commits into from Apr 6, 2022
Merged

[Vue] migrate manage gdpr directive to Vue #19002

merged 14 commits into from Apr 6, 2022

Conversation

diosmosis
Copy link
Member

Description:

This PR is based off of #18993.

Changes:

  • Migrate manage gdpr directive to Vue.

Review

@diosmosis diosmosis marked this pull request as draft March 26, 2022 21:04
@diosmosis diosmosis added this to the 4.9.0 milestone Mar 26, 2022
@diosmosis diosmosis added the Needs Review PRs that need a code review label Apr 2, 2022
@diosmosis diosmosis modified the milestones: 4.9.0, 4.10.0 Apr 2, 2022
@diosmosis diosmosis marked this pull request as ready for review April 2, 2022 21:28
sgiehl
sgiehl requested changes Apr 5, 2022
View reviewed changes
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some minor comments. Otherwise this looks good.

plugins/PrivacyManager/vue/src/ManageGdpr/ManageGdpr.vue Outdated Show resolved Hide resolved
plugins/PrivacyManager/vue/src/ManageGdpr/ManageGdpr.vue Outdated Show resolved Hide resolved
plugins/PrivacyManager/vue/src/ManageGdpr/ManageGdpr.vue Show resolved Hide resolved
@diosmosis
Copy link
Member Author

@sgiehl applied the fixes

@sgiehl sgiehl merged commit 59f26bc into 4.x-dev Apr 6, 2022
@sgiehl sgiehl deleted the vue-manage-gdpr branch April 6, 2022 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl requested changes

@peterhashair peterhashair peterhashair approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review
Projects
None yet
Milestone
4.10.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@diosmosis @sgiehl @peterhashair