Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Vue] remove angularjs libraries from matomo #19502

merged 414 commits into from Nov 7, 2022


Copy link

@diosmosis diosmosis commented Jul 9, 2022


This PR is based off of #19496.


  • Remove angularjs libs from git and from inclusion in CoreHome.php/other controllers.
  • Some code changes to get everything to build w/o angularjs.



…rg/matomo into vue-remove-angularjs-MultiSites
…omo-org/matomo into vue-remove-angularjs-MobileMessaging
…org/matomo into vue-remove-angularjs-Marketplace
…omo-org/matomo into vue-remove-angularjs-MobileMessaging
Copy link
Member Author

@sgiehl updated. requires a travis-scripts pr to be merged too

@diosmosis diosmosis added the Needs Review For pull requests that need a code review. label Oct 17, 2022
Copy link

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far. Let's see if the tests are passing.
The travis PR might need another change though.
Last thing we need to do is to mention the removal of angularjs in the changelog.

core/Common.php Show resolved Hide resolved
Copy link
Member Author

@sgiehl updated

Copy link

github-actions bot commented Nov 4, 2022

This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers

@github-actions github-actions bot added the Stale The label used by the Close Stale Issues action label Nov 4, 2022
@sgiehl sgiehl merged commit b182f0e into 5.x-dev Nov 7, 2022
2 of 4 checks passed
@sgiehl sgiehl deleted the vue-remove-angularjs-final branch November 7, 2022 20:57
@elabuwa elabuwa added the not-in-changelog For issues or pull requests that should not be included in our release changelog on label Nov 22, 2022
bx80 pushed a commit that referenced this pull request Nov 25, 2022
* revert back to suffixing an underscore

* avoid random failure

* built vue files

* add missing vue-entry property + add missing translations

* fixing UI tests locally

* update screenshots

* update CustomAlerts submodule

* add missing translations

* fix spacing

* couple fixes

* more ui test fixes

* make sure installation umd is loaded during installation (as well as translations)

* couple small UI test fixes

* Fix component name case.

* built vue files

* do not use html_attr to escape and in UI tests replace path with escaped slashes so json data gets replaced

* move UploadPluginDialog to CorePluginsAdmin so it will be available when internet access is not available and the Marketplace plugin is deactivated

* correct typing for feedback question input

* update screenshots

* revert last tweak

* styling tweak

* update screenshots and styling tweak

* fix attribute

* Allow composer plugins for dev dependency codesniffer to fix travis builds.

* keep dependent class and rename

* styling tweaks

* update expected screenshot

* update screenshots

* comma spacing tweak

* update screenshots + fix v-show condition

* some small fixes

* fix styling and formatting issues

* fix spacing issue

* fix property name

* update expected screenshots

* get to load in UI

* getting dashboard settings control to work

* styling tweaks

* fix html attribute output for singlemetricview

* fix vue-entry elements

* update expected screenshot

* fixing UI test issues, reintroduce compileAngularComponents (will remove calls in CoreHome PR)

* move function to correct class

* fix order of array elements

* fixing some more issues

* hide the dashboard manager on initial display as before

* styling fixes

* fix styles for widgetized glossary

* update expected screenshots

* fixing DashboardManager UI test that previously used the uiControlObject property

* update device detection demo to be accurate

* update expected screenshots

* fix race condition in dashboard ajax requests/aborts

* start removing angularjs from CoreHome

* remove more angularjs code

* remove angularjs from CustomDimensions plugin

* removing some angularjs files

* remove use of history service, the use of $location from MatomoUrl and the piwikApi service

* remove angularjs service module and filters

* removing more angularjs references

* remove more angular related code, including getAngularDependency()

* update submodules to vue-remove-angularjs branches

* try replacing angularjs expression parsing w/ mathjs/number

* logical operator fixes

* only import what is needed for math.js

* remove some functionality

* optimize math.js use

* convert zen mode code, add --bail option and some output to vue:build

* remove ng-app directive in twig layouts

* ajaxhelper.adapter.ts still required for vanilla ajaxHelper() object

* remove ng-cloak use

* fix datatableactions.vue errors

* do not propagate id param in vue-entry uses

* remove pointless defer

* get zen mode to work, fix couple issues in headermessage vue-entry usage

* move more data table action icon code to vue component from dataTable.js + fix use of angular in ui test JS override code

* couple more data table actions fixes

* UI test fixes + ng-non-bindable no longer needed

* fix more test issues + update some screenshots

* remove another use of isAngularRenderingThePage

* revert screenshot change

* fixing more issues

* move inline script to vue directive + fix a couple vue warnings

* built vue files

* remove inline script in system check widget

* fix some more datatableactions issues

* use VueEntryContainer in _singleWidget.twig

* remove unused inline script from _donate.twig

* update expected screenshots

* fix hide flat icon code

* updating screenshots and try to fix random failure

* fix numeric conversion

* update expected screenshots

* update screenshots

* use common method to load umd file

* get languages dropdown to work

* only add menu translations if installed

* make sure datatableactions vue entry is completely rendered before initing datatable

* correct enriched-headline selector

* update VisitorGenerator submodule

* do not load menu translations during updater as well

* update expected screenshots

* update screenshot

* remove anglarjs libraries

* get code to build w/o angularjs

* update submodule

* update expected screenshot

* remove angular from tsconfig.json

* update submodule

* update submodule

* remove duplicate translations

* remove angularjs from legalnotice

* merge related fixes

* remove angluar mappings

* remove packages/scripts for angularjs unit tests that ran in karma

* remove references to angular in core directory

* rename AngularJS tests suite to ClientTests

* remove angularjs specific escaping in polyfill file

* remove angularjs references in source code/comments + remove unneeded BC code

* remove more angularjs references/deprecated code

* remove more references to angularjs in test files/local docs

* remove templateFile from expected test files

* remove .only() and more <templateFile> occurrences in test files

* update submodule

* update submodule

* update submodule

* submodule update

* fix phpcs

* update changelog and travis scripts

* fix failing test

* fix latest available version styling

* built vue files

* built vue files

* fix test

* submodule

* update expected test files

Co-authored-by: sgiehl <>
Co-authored-by: sgiehl <>
@sgiehl sgiehl removed not-in-changelog For issues or pull requests that should not be included in our release changelog on Needs Review For pull requests that need a code review. Stale The label used by the Close Stale Issues action labels May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

4 participants