Improve no data check in html visualization #19740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgiehl
added
not-in-changelog
peterhashair
approved these changes
Sep 21, 2022
There was a problem hiding this comment.
- Functional review done
- Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
- Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
- Security review done
- Wording review done
- Code review done
- Tests were added if useful/possible
- Reviewed for breaking changes
- Developer changelog updated if needed
- Documentation added if needed
bx80
added a commit
that referenced
this pull request
Sep 30, 2022
…t up from design (#19707) * add copy link button and style * add design copy link add design copy link * Revert "add design copy link" This reverts commit bb081bd. * add link token add link token * update tests update tests * built vue files * update xml tests update xml tests * update UI update UI * built vue files * update ui update ui * Update UsersManagerTest.php update tests * update tests update tests * update tests update tests * Update UsersManager_spec.js update screenshots * update ui update ui * update css update css * built vue files * remove password confirm for invite remove password confirm for invite * built vue files * update css update css * convert vue scoped to less convert vue scoped to less * Update UsersManager.vue fix vue error * update vue tests update vue tests * built vue files * update tests update tests * update ui update ui * update UserSetting token UI update UserSetting token UI * add new screen short copied success add new screen short copied success * revert failed UI revert failed UI * Update plugins/UsersManager/lang/en.json Co-authored-by: Stefan Giehl <stefan@matomo.org> * Update plugins/UsersManager/lang/en.json Co-authored-by: Stefan Giehl <stefan@matomo.org> * Update plugins/UsersManager/lang/en.json Co-authored-by: Stefan Giehl <stefan@matomo.org> * Update plugins/UsersManager/lang/en.json Co-authored-by: Stefan Giehl <stefan@matomo.org> * remove DB field and convert the copy link remove DB field and convert the copy link * update error update error * update notification update notification * built vue files * revert database changes revert database changes * update api and tests update api and tests * built vue files * update padding css update padding css * move global button css to modal move global button css to modal * update modal to global update modal to global * remove invite token remove invite token * Update plugins/CoreHome/vue/src/Notification/Notification.ts * update fonts and screenshots update fonts and screenshots * update fonts update fonts * exclude woff2 file on release check exclude woff2 file on release check * Update plugins/UsersManager/API.php * update tests update tests * remove duplicated remove duplicated * update confirm box update confirm box * built vue files * tidy up some file tidy up some file * update icon and update version number update icon and update version number * update change log and translation update change log and translation * update button trigger generate link twice update button trigger generate link twice * add updates add updates * add missing param add missing param * update missing comma update missing comma * remove un use variable remove un use variable * update tests update tests * built vue files * add password confirm for the invite action and add popup notes add password confirm for the invite action and add popup notes * update vue error update vue error * revert 4.120-b2 update to b4 revert 4.120-b2 update to b4 * update vue error update vue * built vue files * update typescript error update typescript error * update type script update type script * update vue error update vue error * built vue files * update tests update tests * update screenshots update screenshots * update tests update tests * update tests and wording on the popup update tests and wording on the popup * built vue files * adding clipboard copy error in safari etc adding clipboard copy error in safari etc * built vue files * update double error message update double error message * update wording update wording * built vue files * hot fix give default period (#19724) * hot fix give default period hot fix give default period * update to user default period update to user default period * add default date param in templates add default date param in templates * update tests prevent random fail update tests prevent random fail * built vue files * update ui update ui * Improve no data check in html visualization (#19740) * add command copy over http add command copy over http * built vue files * Adding the abililty to exclude specific sites from the site selector (#19738) * Adding the abililty to exclude specific sites from the Vue site selector component. * Adding more time to make sure that the select is loaded before trying to search. * Changed things to filter the site on the server side. * Added a few new test cases. * Increasing amount of time for test. * Updated the omnifixture. * Fixing logic error in view. * Removed collation from omnifixture since it was causing issues. * Switching omnifixture back to 4.x-dev version. * Making just the bare essential changes to make local test fixtures build correctly. * Updating screenshot of API list. * revert OmniFixture-dump to 4.x-dev revert OmniFixture-dump to 4.x-dev Co-authored-by: Peter <peter@innocraft.com> * merge 4.x and update copied success ui tests merge 4.x and update copied success ui tests * rebase to next release rebase to next release * rebase to next release rebase to next release * update safrai and enable copy success and copy again update safrai and enable copy success and copy again * fix Safrai showing random token fix Safrai showing random token * built vue files * Revert "Adding the abililty to exclude specific sites from the site selector (#19738)" This reverts commit a53a628. * update fonts and text update fonts and text * built vue files * update wording update wording * built vue files * Updated UI test screenshots Co-authored-by: peterhashair <peterhashair@users.noreply.github.com> Co-authored-by: Stefan Giehl <stefan@matomo.org> Co-authored-by: snake14 <snake14@users.noreply.github.com> Co-authored-by: Ben <ben.burgess@innocraft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
fixes #18310
Review