SegmentEditor might fail to display suggestions when using PDO\MYSQL #20556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers |
github-actions
bot
added
the
Stale
…ery autocomplete widget does not seem to recognize numeric values
sgiehl
force-pushed
the
segment-editor-autocomplete-non-string-values
branch
from
06947e4
to
c3f0ebd
Compare
sgiehl
approved these changes
Apr 11, 2023
sgiehl
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The jquery autocomplete widget doesn't seem to handle non-string values, like numbers. This issue is visible currently in segments like 'Site time - hour'. Fixed by converting the values to strings after fetching them.
Review