If custom logo feature is disabled, assume it's not enabled even if one is already uploaded #20621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ne is already uploaded. To reproduce: Upload a logo Disable the custom logo feature in the config (`General['enable_custom_logo']=0`) Send yourself an email You will see it still uses the custom logo even though it's disabled
Co-authored-by: Michal Kleiner <mk@011.nz>
|
This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers |
github-actions
bot
added
the
Stale
sgiehl
approved these changes
May 2, 2023
sgiehl
added
Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To reproduce:
General['enable_custom_logo']=0)With this change, once the logo is disabled in config, it will no longer assume it's enabled. See eg https://github.com/matomo-org/matomo/blob/4.14.3-b1/core/View/HtmlReportEmailHeaderView.php#L78 where it checks if logo is enabled but doesn't consider the config setting.
Review