Adds Vue.js instruction tab on no data screen #20790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nfo (#20781) * Added site detection for Vue and added relevant tab and info, #PG-2778 * Minor fix * Updated UI screenshots * Minor fix * Added FAQ link and PR feedback applied * Removed extra spaces and styling changes * Textual update * Updated UI screenshots * Changed to JS_FRAMEWORK instead of vue * Fixed type in methhod name * Updated note2 to not include support for on premise * Updated screenshots * Fix accidental typo in English lang string * Updated UI screenshot * Added z-index for fixed footer no data screen * PR feedback applied * updated screenshot --------- Co-authored-by: Michal Kleiner <michal@innocraft.com>
sgiehl
approved these changes
May 26, 2023
|
Looks good. Will wait for the tests to pass... |
sgiehl
reviewed
May 26, 2023
tests/PHPUnit/Fixtures/EmptySiteWithSiteContentDetectionVue.php
Outdated
Show resolved
Hide resolved
sgiehl
reviewed
May 26, 2023
tests/PHPUnit/Fixtures/EmptySiteWithSiteContentDetectionVue.php
Outdated
Show resolved
Hide resolved
sgiehl
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Added site detection for Vue and added relevant tab and info.
Fixes: #PG-2778
Review