allow running JS tests for a single plugin in tests:run-js

[diosmosis]

Description:

Adds a --plugin=$pluginName option to tests:run-js. This is to fix the JS tests in a premium plugin.

Review

• Functional review done
• Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
• Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
• Security review done
• Wording review done
• Code review done
• Tests were added if useful/possible
• Reviewed for breaking changes
• Developer changelog updated if needed
• Documentation added if needed
• Existing documentation updated if needed

[diosmosis]

@matomo-org/core-reviewers can someone take a look at this PR?

[michalkleiner]

The changes look ok, left one suggestion. Not sure I see how adding the option to run tests for a single plugin instead of all of them fixes an issue for a plugin. Do the tests fail there if run as part of the overall set and not when run in isolation? That could be an indication of a hidden problem somewhere else.

[bx80]

It's useful to be able to run the tests for just one plugin when debugging an issue locally, I think the idea here is to help with fixing the tests in a premium plugin by not having to run all the tests each time 🙂

[michalkleiner]

Yep, definitely in support of the change, just wasn't 100% sure on the PR description.

[michalkleiner]

Looks ok to me but I won't merge it yet so @sgiehl and @bx80 can have a look as well.