New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve handling of incompatible plugins during an update #20868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgiehl
force-pushed
the
improveupdater
branch
30 times, most recently
from
June 12, 2023 11:45
ed0c3cd
to
ebccc8d
Compare
sgiehl
force-pushed
the
improveupdater
branch
10 times, most recently
from
June 16, 2023 14:59
e3d686b
to
8ba0b4d
Compare
…evious major release (e.g. 4.0.0)
bx80
approved these changes
Jul 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This worked for me when updating a 4.15 install with an incompatible plugin, the plugin was disabled and the update completed successfully. Automated tests are all looking good and I can't see any other issues 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Incompatible plugins can currently break the updating process, as the process might try to disable them within the process that is still running with old code. If disabling the plugin triggers code, that was not yet loaded, new files might get loaded, that contain code that can't work with the previously loaded old code.
This PR adds a new set of UI tests that will perform an update from the last (forced) Matomo version. Currently this is
4.15.0
.Note: Running this new tests with updating from 4.14.x resulted in errors, which are now fixed with using 4.15.x
Review