New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No-data translations for Vue.js, Cloudflare and WordPress #20880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalkleiner
added
c: Design / UI
For issues that impact Matomo's user interface or the design overall.
c: Tracking
For issues related to getting tracking data into Matomo.
BHAG-Tracking-OKR-Q2
Needs Review
PRs that need a code review
labels
Jun 12, 2023
sgiehl
force-pushed
the
nodata-translations-cloudflare-vue-wp
branch
from
June 13, 2023 07:02
87a9210
to
1e8be77
Compare
Update Dutch translations based on human feedback, emphasize WP congrats message and create new Clouflare step 8
sgiehl
force-pushed
the
nodata-translations-cloudflare-vue-wp
branch
from
June 13, 2023 07:09
1e8be77
to
6ed74ec
Compare
sgiehl
requested changes
Jun 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a couple of suggestions. Some parts of the German translation were still not correct. Not sure if we missed those when going through.
Co-authored-by: Stefan Giehl <stefan@matomo.org>
11 tasks
11 tasks
sgiehl
removed
c: Design / UI
For issues that impact Matomo's user interface or the design overall.
Needs Review
PRs that need a code review
labels
Aug 1, 2023
sgiehl
added
c: i18n
For issues around internationalisation and localisation.
and removed
c: Tracking
For issues related to getting tracking data into Matomo.
labels
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Update the English version for WordPress no-data screen as requested by PO.
Translate the no-data screens for Vue.js, Cloudflare and Wordpress to Dutch, French, German, Italian and Spanish.
Review