Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No-data translations for Vue.js, Cloudflare and WordPress #20880

Merged
merged 16 commits into from Jun 14, 2023

Conversation

michalkleiner
Copy link
Contributor

Description:

Update the English version for WordPress no-data screen as requested by PO.

Translate the no-data screens for Vue.js, Cloudflare and Wordpress to Dutch, French, German, Italian and Spanish.

Review

@michalkleiner michalkleiner added this to the 5.0.0 milestone Jun 12, 2023
@michalkleiner michalkleiner added c: Design / UI For issues that impact Matomo's user interface or the design overall. c: Tracking For issues related to getting tracking data into Matomo. BHAG-Tracking-OKR-Q2 Needs Review PRs that need a code review labels Jun 12, 2023
@sgiehl sgiehl force-pushed the nodata-translations-cloudflare-vue-wp branch from 87a9210 to 1e8be77 Compare June 13, 2023 07:02
@sgiehl sgiehl force-pushed the nodata-translations-cloudflare-vue-wp branch from 1e8be77 to 6ed74ec Compare June 13, 2023 07:09
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a couple of suggestions. Some parts of the German translation were still not correct. Not sure if we missed those when going through.

plugins/SitesManager/lang/de.json Outdated Show resolved Hide resolved
plugins/SitesManager/lang/de.json Show resolved Hide resolved
plugins/SitesManager/lang/de.json Outdated Show resolved Hide resolved
plugins/SitesManager/lang/de.json Outdated Show resolved Hide resolved
plugins/SitesManager/lang/de.json Outdated Show resolved Hide resolved
plugins/SitesManager/lang/de.json Show resolved Hide resolved
Co-authored-by: Stefan Giehl <stefan@matomo.org>
@sgiehl sgiehl merged commit 9fd54cc into 5.x-dev Jun 14, 2023
17 of 19 checks passed
@sgiehl sgiehl deleted the nodata-translations-cloudflare-vue-wp branch June 14, 2023 07:22
@sgiehl sgiehl removed c: Design / UI For issues that impact Matomo's user interface or the design overall. Needs Review PRs that need a code review labels Aug 1, 2023
@sgiehl sgiehl added c: i18n For issues around internationalisation and localisation. and removed c: Tracking For issues related to getting tracking data into Matomo. labels Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: i18n For issues around internationalisation and localisation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants