Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve handling of deactivating incompatible plugins during update #20882

Merged
merged 1 commit into from Jun 15, 2023

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Jun 13, 2023

Description:

Incompatible plugins are currently deactivated within the initial process performing the update.
This can cause random problems, as at this point disabling a plugin might trigger other code causing to process a mix of old and new code, which can cause random errors being displayed.

To be sure that won't happen anymore we should deactivate the plugins within the second request, which is processed with new code only.

Review

@sgiehl sgiehl added this to the 4.14.x milestone Jun 13, 2023
@sgiehl sgiehl added the Needs Review PRs that need a code review label Jun 13, 2023
@sgiehl sgiehl marked this pull request as ready for review June 13, 2023 14:45
Copy link
Contributor

@bx80 bx80 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a fairly straightforward change, I can't see any obvious issues with disabling the plugins in the second phase 👍

Copy link
Contributor

@michalkleiner michalkleiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me as a code change. In terms of the process I can't judge where it's better.

@sgiehl sgiehl merged commit 87b83b8 into 4.x-dev Jun 15, 2023
17 of 21 checks passed
@sgiehl sgiehl deleted the updateimprovement branch June 15, 2023 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants