Fixing Order metric so that the plural name is used correctly #20917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure which core team member to request a review from. Could one of you please take a look at this PR, @sgiehl @bx80 @michalkleiner ? |
|
@snake14 easiest way is to simply request a review from @matomo-org/core-reviewers |
sgiehl
approved these changes
Jun 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The Order metric was using
Order IDas the plural name instead ofOrders. This PR removes the explicit setting of the translated name so that the plural name is used as expected. This came up because it was confusing customers, especially when selecting metrics in the CustomReports plugin.Jira Issue: PG-2801
Review