Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redesign accept invitation screen #20924

Merged
merged 18 commits into from
Aug 3, 2023
Merged

Redesign accept invitation screen #20924

merged 18 commits into from
Aug 3, 2023

Conversation

AltamashShaikh
Copy link
Contributor

Description:

Improve Onborading flow.
Fixes: #PG-2720

Review

@github-actions
Copy link
Contributor

github-actions bot commented Jul 8, 2023

If you don't want this PR to be closed automatically in 28 days then you need to assign the label 'Do not close'.

@github-actions github-actions bot added the Stale The label used by the Close Stale Issues action label Jul 8, 2023
@michalkleiner michalkleiner removed the Stale The label used by the Close Stale Issues action label Jul 8, 2023
@AltamashShaikh AltamashShaikh added the Do not close PRs with this label won't be marked as stale by the Close Stale Issues action label Jul 10, 2023
@AltamashShaikh AltamashShaikh added the Needs Review PRs that need a code review label Jul 26, 2023
@AltamashShaikh AltamashShaikh marked this pull request as ready for review July 26, 2023 07:16
@bx80 bx80 changed the title Improve Onborading flow Improve Onboarding flow Jul 27, 2023
sgiehl
sgiehl requested changes Jul 27, 2023
View reviewed changes
plugins/Login/images/01_Create password.png Outdated Show resolved Hide resolved
plugins/Login/templates/invitation.twig Outdated Show resolved Hide resolved
plugins/Login/templates/loginLayout.twig Outdated Show resolved Hide resolved
sgiehl
sgiehl requested changes Jul 28, 2023
View reviewed changes
plugins/Login/stylesheets/login.less Outdated Show resolved Hide resolved
@AltamashShaikh
Copy link
Contributor Author

@sgiehl @michalkleiner Is this good to merge or do we need more changes ?

@sgiehl sgiehl changed the title Improve Onboarding flow Redesign accept invitation screen Aug 2, 2023
sgiehl
sgiehl requested changes Aug 2, 2023
View reviewed changes
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left another comment for a small code improvement. Otherwise this looks good

plugins/Login/templates/loginLayout.twig Outdated Show resolved Hide resolved
plugins/Login/templates/loginLayout.twig Outdated Show resolved Hide resolved
@sgiehl sgiehl added this to the 5.0.0 milestone Aug 2, 2023
@sgiehl
Copy link
Member

sgiehl commented Aug 3, 2023

@AltamashShaikh There is a integration test failing that needs to be fixed.

@AltamashShaikh
Copy link
Contributor Author

@AltamashShaikh There is a integration test failing that needs to be fixed.

@sgiehl Thanks, should be fixed now

@sgiehl
Copy link
Member

sgiehl commented Aug 3, 2023

Ok. Will merge this one, once the tests passed.

@sgiehl sgiehl merged commit c7dcb0e into 5.x-dev Aug 3, 2023
16 of 20 checks passed
@sgiehl sgiehl deleted the PG-2720-improve-onboarding branch August 3, 2023 08:17
@sgiehl sgiehl added c: Design / UI For issues that impact Matomo's user interface or the design overall. and removed Needs Review PRs that need a code review Do not close PRs with this label won't be marked as stale by the Close Stale Issues action labels Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalkleiner michalkleiner michalkleiner left review comments

@Javi-Ormaechea Javi-Ormaechea Javi-Ormaechea left review comments

@bx80 bx80 Awaiting requested review from bx80

@sgiehl sgiehl Awaiting requested review from sgiehl

Assignees
No one assigned
Labels
c: Design / UI For issues that impact Matomo's user interface or the design overall.
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@AltamashShaikh @sgiehl @michalkleiner @bx80 @Javi-Ormaechea