Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds new SPA/PWA instruction tab for no data screen #20928

Merged
merged 6 commits into from Jun 26, 2023

Conversation

AltamashShaikh
Copy link
Contributor

Description:

Changes to show SPA/PWA tab for no data screen.
Fixes: #PG-2845

Review

AltamashShaikh and others added 3 commits June 26, 2023 07:22
* Changes to show SPA/PWA tab for no data screen

* UI screenshot updated

* test cases updated

* New textual changes

* Updated UI screenshot and plugin reference

* Fix for UI test

* UI testcase fixed

* Added timeout for spa UI test

* Removed unwanted text from translation

* Updated UI screenshot

* TagManager commit reverted

* Fix possible javascript errors if materialize isn't loaded fast enough

The errors occured in UI demo screenshot tests

---------

Co-authored-by: sgiehl <stefan@matomo.org>
@AltamashShaikh AltamashShaikh changed the base branch from 5.x-dev to 4.x-dev June 26, 2023 02:18
@AltamashShaikh AltamashShaikh added the Needs Review PRs that need a code review label Jun 26, 2023
@AltamashShaikh AltamashShaikh marked this pull request as ready for review June 26, 2023 03:17
@sgiehl sgiehl added this to the 4.15.0 milestone Jun 26, 2023
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems to work as expected

@sgiehl sgiehl merged commit 223f361 into 4.x-dev Jun 26, 2023
15 of 21 checks passed
@sgiehl sgiehl deleted the cherrypick-PG-2845-spa-changes branch June 26, 2023 09:19
@sgiehl sgiehl changed the title Changes to show SPA/PWA tab for no data screen Adds new SPA/PWA instruction tab for no data screen Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants