do not send pretty label to row evolution request for actions tables #20955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diosmosis
added
Needs Review
sgiehl
approved these changes
Jul 3, 2023
sgiehl
added
the
not-in-changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixes an issue caused by #20009. For ActionsDataTables there are no nested
<table>elements sogetPrettyLabel()fails to take into account parent tables. ActionsDataTables, unlike other reports, shouldn't have a unique row identifier property on them, so we don't need to send a custom pretty label from the client JS.Note: the bug can be seen in the UI tests for MediaAnalytics.
Review