Fix Deprecation Warning for trim() Function in awkExistsAndRunsCorrectly() #20969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR, @mindbreaker. The usual approach is to use the null-coalesce operator |
michalkleiner
added
the
not-in-changelog
Co-authored-by: Michal Kleiner <mk@011.nz>
michalkleiner
approved these changes
Jul 6, 2023
|
Thanks @mindbreaker for your contribution 🎉 |
|
Can this fix also please be merged into the current maintained Version 4.x ? |
sgiehl
pushed a commit
that referenced
this pull request
Oct 30, 2023
…tly() (#20969) * Update Process.php * Update: Use null-coalesce operator for null values Co-authored-by: Michal Kleiner <mk@011.nz> --------- Co-authored-by: Michal Kleiner <mk@011.nz>
|
@FabianSchmick I've just cherry-picked that to 4.x, so it will be included in the next release there as well. |
|
Great! Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This pull request addresses a deprecation warning that arises when a null value is passed to the trim() function in the awkExistsAndRunsCorrectly() method.
Changes:
This change prevents the deprecation warning and ensures compatibility with the updated behavior of the trim() function in PHP.
fixes #20959
Review