Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove jquery.browser plugin #21085

Merged
merged 4 commits into from Jul 30, 2023
Merged

Remove jquery.browser plugin #21085

merged 4 commits into from Jul 30, 2023

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Jul 28, 2023

Description:

The jquery.browser plugin only had been used in a couple of places. Those checks were actually very old and meant for browser versions we already dropped support for.

Note: Vue.JS is only running on modern browsers anyway, and many of them are meanwhile based on Chromium (IE/Edge, Opera), Firefox or Safari.
The checks in the browser plugin would meanwhile be inaccurate and sometimes incorrect anyway.

Review

@sgiehl sgiehl added the c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. label Jul 28, 2023
@sgiehl sgiehl added this to the 5.0.0 milestone Jul 28, 2023
@sgiehl sgiehl merged commit cd55e5a into 5.x-dev Jul 30, 2023
16 of 20 checks passed
@sgiehl sgiehl deleted the removejbrowser branch July 30, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants