Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Row evolution does not work for reports with special labels #21234

Merged
merged 1 commit into from Oct 2, 2023

Conversation

snake14
Copy link
Contributor

@snake14 snake14 commented Sep 7, 2023

Description:

Regression fix for 4.x based on PR #21232

Review

@snake14 snake14 added Needs Review PRs that need a code review Regression Indicates a feature used to work in a certain way but it no longer does even though it should. labels Sep 7, 2023
@sgiehl
Copy link
Member

sgiehl commented Sep 7, 2023

@snake14 we should avoid backporting stuff to 4.x-dev unless it fixes security issue or stuff that fully breaks the UI or archiving. Switching back to 4.x-dev to review such things imho costs too much effort. And as Matomo 5 might be released in the coming weeks I can't see a bigger benefit in the backports as there most likely won't be another Matomo 4 release anyway.

@snake14
Copy link
Contributor Author

snake14 commented Sep 7, 2023

@snake14 we should avoid backporting stuff to 4.x-dev unless it fixes security issue or stuff that fully breaks the UI or archiving. Switching back to 4.x-dev to review such things imho costs too much effort. And as Matomo 5 might be released in the coming weeks I can't see a bigger benefit in the backports as there most likely won't be another Matomo 4 release anyway.

@sgiehl Yeah. I guess it's not a breaking change. It just fixes the resource label in subtables in MediaAnalytics. I agree. The plugins team has been stuck switching between 4.x and 5.x for months and it's a time consuming hassle.
I guess we can keep this PR in case we end up having a 4.x patch release in the future?

@github-actions
Copy link
Contributor

This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers

@github-actions github-actions bot added the Stale The label used by the Close Stale Issues action label Sep 15, 2023
@sgiehl sgiehl added this to the 4.15.2 milestone Sep 18, 2023
@sgiehl sgiehl merged commit bcb6895 into 4.x-dev Oct 2, 2023
17 of 21 checks passed
@sgiehl sgiehl deleted the pg-2989-fix-graph-subtable-regression branch October 2, 2023 13:39
@sgiehl sgiehl changed the title Fix regression with subtable labels Row evolution does not work for reports with special labels Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review Regression Indicates a feature used to work in a certain way but it no longer does even though it should. Stale The label used by the Close Stale Issues action
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants