Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

process general goal metrics if no conversions, but site is ecommerce enabled #21265

Merged
merged 1 commit into from Sep 19, 2023
Merged

process general goal metrics if no conversions, but site is ecommerce enabled #21265

merged 1 commit into from Sep 19, 2023

Conversation

diosmosis
Copy link
Member

Description:

If a site has no conversions or orders, but has abandoned carts, then general goal metrics still need to be archived.

Review

@diosmosis
process general goal metrics if no conversions, but site is ecommerce…
6cb7019 
… enabled, as there may be abandoned cart "conversions"
@diosmosis diosmosis added the Regression Indicates a feature used to work in a certain way but it no longer does even though it should. label Sep 16, 2023
@diosmosis diosmosis added this to the 5.0.0 milestone Sep 16, 2023
@diosmosis diosmosis added the Needs Review PRs that need a code review label Sep 16, 2023
@diosmosis diosmosis mentioned this pull request Sep 16, 2023
Merged
11 tasks
sgiehl
sgiehl approved these changes Sep 19, 2023
View reviewed changes
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@sgiehl sgiehl merged commit 1abe74b into 5.x-dev Sep 19, 2023
16 of 20 checks passed
@sgiehl sgiehl deleted the only-abandoned-carts-archive branch September 19, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@diosmosis @sgiehl