Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide page performance row action on totals row #21279

Merged
merged 1 commit into from Sep 20, 2023
Merged

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Sep 19, 2023

Description:

The page performance row action is currently shown for all rows. For the totals row this always shows no values, as the current implementation doesn't work for that.

This PR will simply hide the icon on totals rows for now.

We can consider re-adding that later with a proper implementation with #21251

Review

@sgiehl sgiehl added the Needs Review PRs that need a code review label Sep 19, 2023
@sgiehl sgiehl added this to the 5.0.0 milestone Sep 19, 2023
@sgiehl sgiehl requested a review from a team September 19, 2023 15:54
@bx80 bx80 merged commit b96ee3b into 5.x-dev Sep 20, 2023
17 of 20 checks passed
@bx80 bx80 deleted the performancetotalsrow branch September 20, 2023 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants