Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add method getPageViewId to JavaScript tracker to receive current page view id #21399

Merged
merged 4 commits into from
Nov 3, 2023

Conversation

EPNW-Eric
Copy link
Contributor

I need a way to get the pv_id of a Page View and send it to my backend (through a channel unrelated to matomo). This way I can associate events that happend server-side with a specific page view.

@github-actions
Copy link
Contributor

If you don't want this PR to be closed automatically in 28 days then you need to assign the label 'Do not close'.

@github-actions github-actions bot added the Stale The label used by the Close Stale Issues action label Oct 27, 2023
@EPNW-Eric
Copy link
Contributor Author

I don't want this to go stale. Is there anything to do I can help accelerating merging? I've not gotten any feedback yet...

@github-actions github-actions bot removed the Stale The label used by the Close Stale Issues action label Oct 31, 2023
@sgiehl
Copy link
Member

sgiehl commented Oct 31, 2023

Hi @EPNW-Eric,

Sorry for the delay on this one. In general there should be no reason for not adding that method.
To bring that PR in a mergeable state it would be required to build (and commit) the tracker files.
You can do that by either running ./console development:build-tracker-js or some manual steps. See https://github.com/matomo-org/matomo/blob/5.x-dev/js/README.md#deployment

@EPNW-Eric
Copy link
Contributor Author

I build the tracker 👍

@sgiehl sgiehl added the Needs Review PRs that need a code review label Nov 2, 2023
@sgiehl sgiehl changed the title getPageViewId Add method getPageViewId to JavaScript tracker to receive current page view id Nov 3, 2023
@sgiehl sgiehl added this to the 5.0.0 milestone Nov 3, 2023
@sgiehl sgiehl added the Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. label Nov 3, 2023
@sgiehl sgiehl merged commit 500608e into matomo-org:5.x-dev Nov 3, 2023
23 of 25 checks passed
sgiehl added a commit to matomo-org/developer-documentation that referenced this pull request Nov 3, 2023
caddoo pushed a commit that referenced this pull request Nov 5, 2023
caddoo pushed a commit that referenced this pull request Nov 5, 2023
caddoo pushed a commit that referenced this pull request Nov 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants