Adjust day to fetch new geo location databases when done monthly

[PowerKiKi]

Description:

When geolocation database updates are configured to be done monthly, they were scheduled on the 3rd day of the week, so Wednesday. For months that start on a Wednesday, that means that we tried to fetch a file that might not exist yet.

We now schedule on the 3rd day of the month, as I believe was the original intent of dc98a97 that introduced the behavior a long time ago. So this gives 3 days to db-ip.com to update their files in all cases.

Fixes #18427

Review

• Functional review done
• Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
• Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
• Security review done
• Wording review done
• Code review done
• Tests were added if useful/possible
• Reviewed for breaking changes
• Developer changelog updated if needed
• Documentation added if needed
• Existing documentation updated if needed

[PowerKiKi]

I think the CI failures are unrelated to this PR, but could somebody confirm that, please ?

[michalkleiner]

Thank you for the contribution @PowerKiKi. My instinct says this would help with the issue but doesn't really address the possibility the files are not yet available, regardless of what day of the month or week the check is performed. I'd say we should address that rather than just pushing the check a few days back.

[PowerKiKi]

That makes senses to also better handle the failed fetch. But I think they are complementary.

The present situation where the delay is between 0 to 6 days, "randomly", depending on the current month, does not make any sense to me. So I think it should be fixed anyway.

Then, in addition to that, having a mechanism that gracefully handle failure by, maybe, trying again the next day, until success, could be a further improvement. But I don't think I'd have time to work on that myself.

[tassoman]

@PowerKiKi solution is an efficient edit to fix an actual software malfunction. The service providing GEOIP updates, may needs from 3 to 6 hours to get things done. Also it rarely happens.
So I wouldn't address more effort than this, because, having it logged as an ERROR it's already enough to manage manually.
Having a feature for 404 management of GEOIP data it's out the scope of scheduled jobs.

[sgiehl]

I'm going to merge this one. Using setDayOfWeek before was imho more likely a mistake and setDay is more "correct". We anyway should aim to implement a proper handling of non existing databases at a later step.