Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix operator handling in subquery segment values #21529

Merged
merged 3 commits into from Nov 13, 2023
Merged

Fix operator handling in subquery segment values #21529

merged 3 commits into from Nov 13, 2023

Conversation

mneudert
Copy link
Member

@mneudert mneudert commented Nov 13, 2023 •
edited

Description:

Fixes #19617

Apply #21506

Review

@mneudert @michalkleiner
Fix operator handling in subquery segment values (#21506)
9441b28 
* Add tests for subquery segments

* Fix operator handling in subquery segment values

* Escape segment values using separate method

* Quote delimiter pattern for regex usage

Co-authored-by: Michal Kleiner <michal@innocraft.com>

---------

Co-authored-by: Michal Kleiner <michal@innocraft.com>
@mneudert mneudert added Bug For errors / faults / flaws / inconsistencies etc. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Nov 13, 2023
@mneudert mneudert added this to the 4.16.0 milestone Nov 13, 2023
@mneudert mneudert requested a review from a team November 13, 2023 12:59
@mneudert mneudert linked an issue Nov 13, 2023 that may be closed by this pull request
Segment with 'Does not contain' operand is invalid if comma is in value #19617
Closed
@mneudert mneudert removed the Needs Review PRs that need a code review label Nov 13, 2023
@mneudert mneudert removed the request for review from a team November 13, 2023 13:35
@mneudert mneudert requested a review from a team November 13, 2023 14:35
@mneudert mneudert added the Needs Review PRs that need a code review label Nov 13, 2023
sgiehl
sgiehl approved these changes Nov 13, 2023
View reviewed changes
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sgiehl sgiehl merged commit 5078d02 into 4.x-dev Nov 13, 2023
15 of 21 checks passed
@sgiehl sgiehl deleted the apply-21506 branch November 13, 2023 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

Assignees
No one assigned
Labels
Bug For errors / faults / flaws / inconsistencies etc. Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.16.0
Development

Successfully merging this pull request may close these issues.

Segment with 'Does not contain' operand is invalid if comma is in value
2 participants
@mneudert @sgiehl