Make page performance overlay work with flattened reports #21786
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Pages reports provide a row action that will open the page performance report for a specific row. When viewing any action report in normal view that works like a charm. But when the report is changed to be flattened the overlay doesn't show any data anymore.
The reason for this is, that the API request performed for the overlay didn't get the
flat
parameter passed through. This causes the provided label (action url) not to be found in the report.Passing through the
flat
parameter fixes this problem and the data is displayed correctly again.fixes #17807
Review