Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make page performance overlay work with flattened reports #21786

Merged
merged 3 commits into from Jan 18, 2024
Merged

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Jan 8, 2024

Description:

Pages reports provide a row action that will open the page performance report for a specific row. When viewing any action report in normal view that works like a charm. But when the report is changed to be flattened the overlay doesn't show any data anymore.

The reason for this is, that the API request performed for the overlay didn't get the flat parameter passed through. This causes the provided label (action url) not to be found in the report.

Passing through the flat parameter fixes this problem and the data is displayed correctly again.

fixes #17807

Review

@sgiehl sgiehl added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Jan 8, 2024
@sgiehl sgiehl added this to the 5.0.2 milestone Jan 8, 2024
@sgiehl sgiehl added the Needs Review PRs that need a code review label Jan 8, 2024
@sgiehl sgiehl requested a review from a team January 8, 2024 17:30
@sgiehl sgiehl merged commit a6a9456 into 5.x-dev Jan 18, 2024
23 of 25 checks passed
@sgiehl sgiehl deleted the dev-14220 branch January 18, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Page Performance reports don't show data (empty graph) when viewing performance for a flattened page URL
3 participants