New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display notification about not yet processed data also when visits log is disabled #22178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgiehl
added
Enhancement
For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Regression
Indicates a feature used to work in a certain way but it no longer does even though it should.
labels
May 2, 2024
sgiehl
commented
May 2, 2024
…s log is disabled
mneudert
approved these changes
May 7, 2024
Was just passing by so left a few code comments, I didn't functionally check this. |
Co-authored-by: Michal Kleiner <michal@innocraft.com>
Co-authored-by: Michal Kleiner <michal@innocraft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Enhancement
For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Needs Review
PRs that need a code review
Regression
Indicates a feature used to work in a certain way but it no longer does even though it should.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
When viewing data for a period that includes today, we are currently displaying a notification if no archive data is available yet, but there has been raw data tracked already.
This currently does not work when the visits log is disabled in config or only for the current site, as we are checking for raw data availability using the API method
Live.getLastVisitsDetails
. But this one is disabled when the visits log is not available.To be able to show a similar notification when there has been raw data tracked, but the visits log is disabled, this PR introduces a new API method
Live.getMostRecentVisitsDateTime
, which simply returns the last actions date time that happened (in a certain period).The check for raw data availability has been switched to use the new API method in favor of
Live.getLastVisitsDetails
. Same was applied to the check done on the no data page.In case the visits log is disabled, no archives have been built yet, but raw data was tracked this notification will be shown:
fixes #19736
Review