Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed JavaScript Tracking Code generation to use "//" #344

Merged
merged 5 commits into from Sep 7, 2014
Merged

Changed JavaScript Tracking Code generation to use "//" #344

merged 5 commits into from Sep 7, 2014

Commits on Jul 5, 2014

  1. Changed JavaScript Tracking Code generation to use "//", instead of v… 

    …erifying whether the site is using "https", or not, and generating a corresponding URL.

"//" has been part of the RFC for well over 18 years. It has been confirmed to work in all major browsers (Firefox, Chrome, IE, Opera).

References:
- RFC 1808 Section 4: http://www.ietf.org/rfc/rfc1808.txt
- RFC 3986 Section 5.2: http://www.ietf.org/rfc/rfc3986.txt
- Stack Overflow QA 1: http://stackoverflow.com/q/4659345/238722
- Stack Overflow QA 2: http://stackoverflow.com/q/6785442/238722
    @JesseNaranjo
    JesseNaranjo committed Jul 5, 2014
    Configuration menu
    Copy the full SHA
    d8d0594 View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2014

  1. First attempt at fixing failing tests.

    @JesseNaranjo
    JesseNaranjo committed Jul 24, 2014
    Configuration menu
    Copy the full SHA
    2318edd View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' of https://github.com/piwik/piwik

    @JesseNaranjo
    JesseNaranjo committed Jul 24, 2014
    Configuration menu
    Copy the full SHA
    ac43db2 View commit details
    Browse the repository at this point in the history

  3. Missed one correction on the failing tests.

    @JesseNaranjo
    JesseNaranjo committed Jul 24, 2014
    Configuration menu
    Copy the full SHA
    a6639a7 View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2014

  1. Added the protocol-agnostic URL format to the Tracker's fallback image.

    @JesseNaranjo
    JesseNaranjo committed Sep 4, 2014
    Configuration menu
    Copy the full SHA
    e7760f2 View commit details
    Browse the repository at this point in the history