make the opt-out form work even if JavaScript is disabled #5849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the closest existing translation key would be |
|
Done, @tsteur. I've updated the 2nd image accordingly. |
tsteur
added a commit
that referenced
this pull request
Jul 21, 2014
…-javascript make the opt-out form work even if JavaScript is disabled
|
Thx! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the opt-out form work even if JavaScript is disabled. I've attached two screenshots, showing the current state and the new "JS is disabled, so we need a proper submit button" state, both using the default size of 600x200 pixels for the iframe.
previous state with and without JavaScript + new state with JavaScript:
new state without JavaScript:
The result is not that beautiful, but should still fit into the iframe in every language.
It might be a good idea to make the button text translatable, as the browser's language is just used currently. Which translation key and English text should I use?