New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
code cleanup #5872
code cleanup #5872
Conversation
Hi @craue |
@halfdan: Really? I separated them on purpose. |
Imho it is fine as it is. Every commit is fixing a different type. |
@sgiehl In that case we can probably create a few hundred more commits.. I'd like to keep the history clean. |
Sure. But having more 'atomic' commits makes it easier to revert them if required. And it is easier to understand why something was changed. |
+1 for @sgiehl atomic commits. @craue the tests fail as there were whitespace changes / newline changes in |
@tsteur: Sure, I've excluded the |
Would you mind checking |
Done, @tsteur. |
Thx! |
Another one. 馃槒