Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Skip to content" feature when user presses tab key (accessibility) #7025

Merged
merged 30 commits into from
Jan 15, 2015
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
fa619f5
added in a label tag with a none display and an id for the search.
Jan 14, 2015
bb2ac07
changed all css within '.widgetName h3{' to make all the headings of …
Jan 14, 2015
08d3295
changed the blue colour used repeatedly through the site to make it d…
Jan 14, 2015
8b4e40a
added a link at the top of the page that links to another link at the…
Jan 14, 2015
52d7930
added css for the skip to content links so it will be off the screen …
Jan 14, 2015
12e5e99
added a link at the top of the main content which is where the user w…
Jan 14, 2015
4f474f8
making an accessible skip to content button for users who are using t…
Jan 14, 2015
9aca4cb
added in an accessible skip to content button for people who go throu…
Jan 15, 2015
b2a7418
css changes to the skip to content button
Jan 15, 2015
fee9ff1
Merge branch 'master' of https://github.com/flodrwho/piwik into skip
Jan 15, 2015
e415649
Fix curl timeout not set completely: this could result in Piwik hang …
mnapoli Jan 13, 2015
4147c87
Fix #6980 "Array to string conversion" notice
mnapoli Jan 13, 2015
75083be
Remove dependency on Piwik DI in generate:travis-yml command (for tra…
Jan 13, 2015
c28adc4
Refs #6968, add --w3c-fields option to log importer so log files in W…
Jan 13, 2015
be3ad40
Add ability to customise the font family in HTML email reports
mattab Jan 13, 2015
9276c8d
Scheduled reports, set the table header font to uppercase
mattab Jan 13, 2015
fcdbae6
in scheduled reports, put the blue background row first, then white
mattab Jan 13, 2015
4b9336e
Make table header font normal weight instead of bold
mattab Jan 13, 2015
1ef8e91
added in a label tag with a none display and an id for the search.
Jan 14, 2015
a0f341e
changed all css within '.widgetName h3{' to make all the headings of …
Jan 14, 2015
790afc7
changed the blue colour used repeatedly through the site to make it d…
Jan 14, 2015
144db93
added a link at the top of the page that links to another link at the…
Jan 14, 2015
3cd03a5
added css for the skip to content links so it will be off the screen …
Jan 14, 2015
5df5b0e
added a link at the top of the main content which is where the user w…
Jan 14, 2015
84f2c59
making an accessible skip to content button for users who are using t…
Jan 14, 2015
fc3fc2b
added in an accessible skip to content button for people who go throu…
Jan 15, 2015
2372a36
css changes to the skip to content button
Jan 15, 2015
6b37b0f
fix to search label + added alt to Rows to display selector
Jan 15, 2015
38aa80d
merged conflict
Jan 15, 2015
4eb6895
merged conflic resolved
Jan 15, 2015
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion plugins/CoreHome/lang/en.json
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@
"ShortMonthFormat": "%shortMonth% %longYear%",
"ShortWeekFormat": "%dayFrom% %shortMonthFrom% - %dayTo% %shortMonthTo% %shortYearTo%",
"ShowJSCode": "Show the JavaScript code to insert",
"SkipToContent": "Skip to content",
"SubscribeAndBecomePiwikSupporter": "Proceed to a secure credit card payment page (Paypal) to become a Piwik Supporter!",
"SupportPiwik": "Support Piwik!",
"TableNoData": "No data for this table.",
Expand All @@ -63,4 +64,4 @@
"UndoPivotBySubtable": "This report has been pivoted %s Undo pivot",
"PivotBySubtable": "This report is not pivoted %s Pivot by %s"
}
}
}
14 changes: 13 additions & 1 deletion plugins/CoreHome/stylesheets/coreHome.less
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,18 @@ h3 {
width: auto;
}


.accessibility-skip-to-content{
position:absolute;
left:-10000px;
}

.accessibility-skip-to-content:focus{
display: block;
position: absolute;
left: 50%;
}

/* Calendar*/
div.ui-datepicker {
font-size: 62.5%;
Expand Down Expand Up @@ -257,4 +269,4 @@ a.Piwik_Popover_Error_Back {

/* Used to link within content text, without adding visual clutter */
.linkContent { color:#333; text-decoration:none}
.linkContent:hover { text-decoration:underline;}
.linkContent:hover { text-decoration:underline;}
5 changes: 3 additions & 2 deletions plugins/CoreHome/templates/_dataTableFooter.twig
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,8 @@

{% if properties.show_search %}
<span class="dataTableSearchPattern">
<input type="text" class="searchInput" length="15" />
<label for="widgetSearch_{{ properties.report_id }}" style="display:none;"> {{ 'General_Search'|translate }} {{ visualization.config.translations.label }}</label>
<input id="widgetSearch_{{ properties.report_id }}" type="text" class="searchInput" length="15" />
<input type="submit" value="{{ 'General_Search'|translate }}" />
</span>
{% endif %}
Expand Down Expand Up @@ -81,7 +82,7 @@

</div>
<div class="limitSelection {% if not properties.show_pagination_control and not properties.show_limit_control %} hidden{% endif %}"
title="{{ 'General_RowsToDisplay'|translate }}"></div>
title="{{ 'General_RowsToDisplay'|translate }}" alt="{{ 'General_RowsToDisplay'|translate }}"></div>
<div class="tableConfiguration">
<a class="tableConfigurationIcon" href="#"></a>
<ul>
Expand Down
3 changes: 2 additions & 1 deletion plugins/CoreHome/templates/_indexContent.twig
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
{% import 'ajaxMacros.twig' as ajax %}
<div class="pageWrap">
<a name="main"></a>
{% include "@CoreHome/_notifications.twig" %}
<div class="top_controls">
{% include "@CoreHome/_periodSelect.twig" %}
Expand All @@ -17,4 +18,4 @@
<div class="clear"></div>
</div>

<br/><br/>
<br/><br/>
1 change: 1 addition & 0 deletions plugins/CoreHome/templates/_topScreen.twig
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
<div id="header">
<a href='#main' tabindex="0" class="accessibility-skip-to-content">{{'SkipToContent'|translate}}</a>
{% include "@CoreHome/_logo.twig" %}
{% include "@CoreHome/_topBar.twig" %}
</div>
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
<div class="jqplot-graph">
<div alt="{{ 'Mobile_StaticGraph'|translate }}" class="jqplot-graph">
<div class="piwik-graph" data-data="{{ visualization.getGraphData(dataTable, properties)|json_encode }}"></div>
</div>
</div>
14 changes: 7 additions & 7 deletions plugins/Dashboard/stylesheets/dashboard.less
Original file line number Diff line number Diff line change
Expand Up @@ -112,20 +112,20 @@
.widgetTop {
cursor: move;
font-size: 10pt;
font-weight: bold;
font-weight: normal;
padding-bottom: 4px;
}

.widgetTopHover {
}

.widgetName {
font-size: 18px;
padding: 2px 0 0 10px;
.widgetName h3{
font-size: 15px;
padding: 0px;
margin: 2px;
font-weight: normal;
color: #fff;
text-shadow: 1px 1px 2px #7e7363;
margin-top: 0;
color: #0D0D0D;
text-shadow: none;
}

// Overriding some dataTable css for better dashboard display
Expand Down
2 changes: 1 addition & 1 deletion plugins/Morpheus/stylesheets/less/_colors.less
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
// Brand colors
// Variable pattern: @color-<color>-<modifier>
@color-black-piwik: #0d0d0d;
@color-blue-piwik: #1e93d1;
@color-blue-piwik: #4183C4;
@color-red-piwik: #d4291f;
@color-green-brandSocial: #009874;
@color-blue-brandSocial: #3b5998;
Expand Down