Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move archiving code to RecordBuilders #63

Merged
merged 2 commits into from
Jul 10, 2023
Merged

Conversation

diosmosis
Copy link
Member

Description:

This PR depends on matomo-org/matomo#20719 which should be reviewed and merged first.

Changes:

  • Move archiving logic to new RecordBuilder classes.

Review

@diosmosis diosmosis added this to the Current sprint milestone May 20, 2023
@diosmosis diosmosis removed this from the Current sprint milestone May 30, 2023
@diosmosis diosmosis modified the milestone: Current sprint Jun 28, 2023
@sgiehl
Copy link
Member

sgiehl commented Jul 10, 2023

@diosmosis I've increased the minimum required Matomo version in this PR to 5.0.0-b4, as record builders weren't available before. This might need to be changed for all other plugin PRs as well, otherwise tests for minimum required versions will fail.

Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look fine. Tests are passing 👍

@sgiehl sgiehl merged commit 87f26b5 into 5.x-dev Jul 10, 2023
5 checks passed
@sgiehl sgiehl deleted the bandwidth-record-builders branch July 10, 2023 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants