Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation - OAuth Client Credentials (internal) available only for G-Suite users #114

Open
pbdname opened this issue Aug 26, 2020 · 10 comments

Comments

@pbdname
Copy link

pbdname commented Aug 26, 2020

One of the necessary steps to use this plugin is creating OAuth Client Credentials. The tutorial instructs user to choose "interal" type, but it is (now) available only to G-Suite users. Other Google users can choose only "external" type, which comes with some limitations:

In this mode, your app is available to any user with a Google Account. External apps that request sensitive or restricted user data must first be verified by Google. This process may take 4–6 weeks. In addition, if you selected restricted scopes, you'll need to go through an independent security review, which can cost $15k–$75k.

The documentation should mention in Requirements chapter the need for G-Suite account.

@tsteur
Copy link
Member

tsteur commented Aug 26, 2020

Thanks @pbdname do you maybe have a link with more information about this where it says it requires a G-Suite account? That be great.

@tsteur
Copy link
Member

tsteur commented Aug 26, 2020

image
image

fyi some screens. It is indeed not possible to select "Internal"

@pbdname
Copy link
Author

pbdname commented Aug 26, 2020

fyi some screens. It is indeed not possible to select "Internal"

Same for me. As "normal" Google user, I cannot select "internal" and only the popup, that @tsteur posted, is displayed.

screenshot-2020-08-26-T22-25-22

@tsteur
Copy link
Member

tsteur commented Aug 27, 2020

Note:

I just tested it and was able to successfully connect type "external" with Matomo without being "verified". However, while authorizing a user Google was showing this warning which can be skipped:
image

As maybe no restricted and no sensitive scopes are being requested things might just still work and no long review process is needed. There would then be also no cost.

I couldn't fully test it though because I don't have a GA account.

@sgiehl
Copy link
Member

sgiehl commented Aug 27, 2020

The same actually also applies for SearchPerformance and Advertising plugin. Both also require OAuth consent. But I just created a external OAuth consent with access to SearchConsole API, and with that there isn't any warning shown, seems that only happens with Analytics API

@tsteur
Copy link
Member

tsteur commented Sep 2, 2020

@sgiehl will we need to update the guides for these 2 plugins to update the type to external?

@tsteur
Copy link
Member

tsteur commented Sep 3, 2020

@mattab @diosmosis @sgiehl
I just tested the import using Type=External and it worked for me.

I suggest we adjust all those three guides (Importer, Search keywords and Paid Advertising) to use Internal should they have a gsuite account, and External otherwise. We'd also need to mention that we don't require any sensitive or restricted scopes which is why no long verification process (and therefore no cost) will be needed. With external type they may see a warning like this: #114 (comment) but it can be safely ignored.

Would need to document this all. At least that what it looks like for me

@diosmosis
Copy link
Member

added to the importer docs:

image

@diosmosis
Copy link
Member

changed "session" to "section" in the docs

@Starker3
Copy link

We've updated the guide for creating OAuth credentials here: https://matomo.org/docs/google-analytics-importer/#1-creating-google-oauth-client-config

If anyone would like to test and give us feedback in case anything needs to be changed or improved, that would be very welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants