Skip to content

Commit

Permalink
Remove use of deprecated test bases and try to get new test to fail c…
Browse files Browse the repository at this point in the history
…orrectly.
  • Loading branch information
diosmosis committed Nov 25, 2014
1 parent 58a9cc9 commit 04b2642
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
6 changes: 3 additions & 3 deletions tests/Integration/LdapIntegrationTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -8,16 +8,16 @@
*/
namespace Piwik\Plugins\LoginLdap\tests\Integration;

use DatabaseTestCase;
use Piwik\Common;
use Piwik\Db;
use Piwik\Log;
use Piwik\Config;
use Piwik\Plugins\LoginLdap\Ldap\LdapFunctions;
use Piwik\Tests\Fixture;
use Piwik\Tests\Framework\Fixture;
use Piwik\Plugins\UsersManager\API as UsersManagerAPI;
use Piwik\Tests\Framework\TestCase\IntegrationTestCase;

abstract class LdapIntegrationTest extends DatabaseTestCase
abstract class LdapIntegrationTest extends IntegrationTestCase
{
const SERVER_HOST_NAME = 'localhost';
const SERVER_PORT = 389;
Expand Down
4 changes: 2 additions & 2 deletions tests/Integration/LdapUserSynchronizationTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -230,11 +230,11 @@ public function test_CorrectExistingUserUpdated_WhenUserEmailSuffixUsed()
// authenticate via ldap to add the user w/ the email suffix
$this->authenticateViaLdap($login = 'msmarvel', $pass = 'enrogue');

$user = $this->getUser('msmarvel');
$user = $this->getUser('msmarvel@wrandh.com');

$this->assertNotEmpty($user);

// authenticate again to make sure the correct user is updated
// authenticate again to make sure the correct user is updated and we didn't try to add again
$this->authenticateViaLdap($login = 'msmarvel', $pass = 'enrogue');
}

Expand Down

0 comments on commit 04b2642

Please sign in to comment.