Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added option to bypass password confirmation prompt #320

Merged
merged 3 commits into from
Jan 13, 2023
Merged

Added option to bypass password confirmation prompt #320

merged 3 commits into from
Jan 13, 2023

Conversation

AltamashShaikh
Copy link
Contributor

Description:

Added option to bypass password confirmation prompt
Fixes: #PG-1594.

Review

@AltamashShaikh AltamashShaikh marked this pull request as ready for review January 12, 2023 08:25
snake14
snake14 approved these changes Jan 12, 2023
View reviewed changes
Copy link
Contributor

@snake14 snake14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good. I confirmed that the password confirmation defaults to off when the LDAP plugin is enabled, but that the config allows it to be enabled. 👍

config/config.php Outdated Show resolved Hide resolved
@AltamashShaikh AltamashShaikh merged commit 42dc785 into 4.x-dev Jan 13, 2023
@AltamashShaikh AltamashShaikh deleted the PG-1594-disable-password-confirmation branch January 13, 2023 03:27
@AltamashShaikh AltamashShaikh mentioned this pull request Mar 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snake14 snake14 snake14 approved these changes

Assignees
No one assigned
Labels
Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AltamashShaikh @snake14