Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run tests against PHP 7 #88

Closed
J0WI opened this issue Nov 23, 2018 · 3 comments
Closed

Run tests against PHP 7 #88

J0WI opened this issue Nov 23, 2018 · 3 comments

Comments

@J0WI
Copy link
Contributor

J0WI commented Nov 23, 2018

PHP 5.6 reaches EOL by the end of the year and 5.5 is already unsupported.
See also matomo-org/matomo#13285

plugin-QueuedTracking/.travis.yml

Lines 5 to 9 in e538655

php:
- 5.6
- 5.5
# - hhvm

@J0WI J0WI mentioned this issue Nov 23, 2018
Open
@tsteur
Copy link
Member

tsteur commented Nov 23, 2018

Could just add 7.0 or 7.1 and see if tests work 👍

@J0WI
Copy link
Contributor Author

J0WI commented Nov 23, 2018

Not sure if it's worth to add PHP 7.0, it's already EOL in a few days:
https://secure.php.net/supported-versions.php

@tsteur
Copy link
Member

tsteur commented Nov 23, 2018

Meant just as an example :)

@tsteur tsteur closed this as completed in 89ce132 Jul 17, 2019
tsteur added a commit that referenced this issue Jul 17, 2019
@tsteur
Merge pull request #95 from J0WI/patch-1
4067e19 
Run tests against PHP 7 (fix #88)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tsteur @J0WI