New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Vue] migrate debugging angularjs controller to vue component #432
Conversation
Note: UI test failure looks random. Also, note that this will break existing previews since the HTML appears to be saved on the filesystem. Disabling and enabling the preview fixes it. If needed we can perhaps disable all previews in an update in core. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@diosmosis
We should update it in core, since users might complain that after a recent upgrade Matomo Tag Manager preview is not working.
Also, we can regenerate all the containers or make use of this method generateContainerIfHasPreviewRelease to regenerate only when preview enabled.
…r:regenerate-released-containers command.
@AltamashShaikh created a core PR here: matomo-org/matomo#18921 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@diosmosis I just saw this
https://github.com/matomo-org/tag-manager/blob/4.x-dev/TagManager.php#L55
On update we are triggering regenerateReleasedContainers
so we don't need the change in core, we can keep the plugin changes but no need to make changes in core
@AltamashShaikh oh I see, that's interesting, I'll close the core PR, nice catch, thanks! |
Description:
Changes:
Review