Improve JavaScript reliability #599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
| @@ -115,7 +120,7 @@ | |||
|
|
|||
| var setCustomDimensionIndexes = []; | |||
| indexesToRemove = []; | |||
| var _paq = JSON.parse(JSON.stringify(initialPaq)); | |||
| var localPaq = JSON.parse(JSON.stringify(initialPaq)); | |||
There was a problem hiding this comment.
Just for my understanding was this variable name conflicting with tests ?
There was a problem hiding this comment.
That's the only thing that I can think of, cause my change around window._paq didn't make the build pass.
AltamashShaikh
approved these changes
Feb 8, 2023
bx80
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The JavaScript is failing for some reason. This is an attempt to fix it.
Review