Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'disable campaign parameters tracking' setting #766

Merged

Conversation

michalkleiner
Copy link
Contributor

@michalkleiner michalkleiner commented Mar 13, 2024

Description:

Companion PR to matomo-org/matomo#22013 enabling the same setting for MTM.

The new variable is available and when new version of the container is published after the checkbox is checked, it is correctly returned in the list of configurations for the container and campaign params are correctly stripped.

Removing the check, publishing a new version and tracking a link with campaign params after that works as expected again.

screenshot - disable campaign tracking MTM variable
screenshot - disable campaign tracking MTM

Review

Copy link
Contributor

@snake14 snake14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from the one change request, this looks like it should work. I did functional testing with the change that I suggested and it appeared to work as expected.

Template/Tag/MatomoTag.web.js Outdated Show resolved Hide resolved
michalkleiner and others added 2 commits March 18, 2024 11:34
Co-authored-by: Jacob R <snake14@users.noreply.github.com>
Copy link
Contributor

@snake14 snake14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@AltamashShaikh AltamashShaikh merged commit 590f568 into 5.x-dev Mar 18, 2024
4 checks passed
@AltamashShaikh AltamashShaikh deleted the dev-17829-feature-consent-tracker-code-generator branch March 18, 2024 00:09
@sgiehl sgiehl changed the title Add 'require consent for campaigns tracking' setting Add 'disable campaign parameters tracking' setting Apr 8, 2024
@MatomoForumNotifications

This pull request has been mentioned on Matomo forums. There might be relevant details there:

https://forum.matomo.org/t/new-tracking-functions-disablecampaignparameters-enablecampaignparameters/58176/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request Needs Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants