-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 'disable campaign parameters tracking' setting #766
Add 'disable campaign parameters tracking' setting #766
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside from the one change request, this looks like it should work. I did functional testing with the change that I suggested and it appeared to work as expected.
Co-authored-by: Jacob R <snake14@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍
This pull request has been mentioned on Matomo forums. There might be relevant details there: |
Description:
Companion PR to matomo-org/matomo#22013 enabling the same setting for MTM.
The new variable is available and when new version of the container is published after the checkbox is checked, it is correctly returned in the list of configurations for the container and campaign params are correctly stripped.
Removing the check, publishing a new version and tracking a link with campaign params after that works as expected again.
Review