Autodetect minimum php version of plugins by checking plugin.json. #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| $phpRequirement = $pluginJsonContents['require']['php']; | ||
| if (!preg_match('/>=([0-9]+\.[0-9]+\.[0-9]+)/', $phpRequirement, $matches)) { | ||
| $this->log("info", "Cannot detect minimum php version from php requirement: '$phpRequirement'"); |
|
@diosmosis I left a comment, otherwise looks good. Please merge it + update submodule in piwik/piwik 👍 |
diosmosis
force-pushed
the
autodetect_min_php
branch
from
cc0dbdb
to
77de6c6
Compare
diosmosis
added a commit
that referenced
this pull request
Oct 20, 2015
Autodetect minimum php version of plugins by checking plugin.json when generating .travis.yml files.
diosmosis
pushed a commit
to matomo-org/matomo
that referenced
this pull request
Oct 20, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title, generate:travis-yml will now try to detect the minimum PHP version from plugin.json and if found, test against this instead of 5.3.3.
@mattab Can you do a quick review?