Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow plugins to easily use the Travis trusty distribution #38

Merged
merged 4 commits into from
Dec 18, 2017
Merged

Allow plugins to easily use the Travis trusty distribution #38

merged 4 commits into from
Dec 18, 2017

Conversation

mneudert
Copy link
Member

The fork commit obviously has to be removed for merging. It is currently only in place to ensure a test plugin can be used with the new generator option.

[refs matomo-org/matomo#11986]

@mneudert
Copy link
Member Author

Running the travis.yml generator should not yield any modifications to existing files for both core or plugins. The example plugin (AnonymousPiwikUsageMeasurement) has an added --sudo-false --dist-trusty to switch the environment.

@mattab mattab added this to the Current sprint milestone Dec 14, 2017
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mneudert LGTM. Would you remove the last commit, so we can merge?

@mneudert
Copy link
Member Author

Removed the the fork commit both here and in linked PRs. If I did not mess up somewhere the plugin PR should succeed once re-run after merging here and main repo.

@sgiehl sgiehl merged commit 5948ae1 into matomo-org:master Dec 18, 2017
@mneudert mneudert deleted the plugin-trusty branch December 18, 2017 19:24
@innocraft-automation innocraft-automation removed this from the Current sprint milestone Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants