Tech-debt: add missing Javadoc and update code formatting #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matoos32
commented
Dec 5, 2022
framework/src/main/java/com/jfcbuilder/builders/XYDrawableBuilder.java
Outdated
Show resolved
Hide resolved
matoos32
commented
Dec 5, 2022
framework/src/main/java/com/jfcbuilder/builders/XYImageBuilder.java
Outdated
Show resolved
Hide resolved
matoos32
commented
Dec 5, 2022
framework/src/main/java/com/jfcbuilder/builders/XYImageBuilder.java
Outdated
Show resolved
Hide resolved
matoos32
commented
Dec 5, 2022
framework/src/main/java/com/jfcbuilder/builders/XYPolygonBuilder.java
Outdated
Show resolved
Hide resolved
matoos32
commented
Dec 5, 2022
matoos32
commented
Dec 5, 2022
matoos32
force-pushed
the
javadoc-updates
branch
from
3ff7d40
to
987bd1c
Compare
|
All findings resolved. Tested on Linux with Java 8 and 11. To back-test gapless chart annotations with Java 8 I commented out the shape builder annotations (workaround to issue #71) Tested on Windows with Java 11. No new issues observed. Will merge this now. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.