Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Container with ngn class can interfere with other fixed-position divs #5

Closed
antch opened this issue Dec 12, 2014 · 2 comments
Closed

Comments

@antch
Copy link

antch commented Dec 12, 2014

Currently, ngn class defines a style of display: block. If there is another container on the page with a fixed position (a "full-screen" div, for example) the ng-notify div can interfere with the ability to focus on elements in the other div. Once a notification is displayed/hidden (and the style is set to none) it is no longer an issue.

For my case I was able to fix it by overriding the display style:

div.ngn {
    display: none;
}

For my use case this works fine, though I'm not sure what impacts it might have with other ng-notify configuration options.

matowens added a commit that referenced this issue Dec 16, 2014
@matowens
Copy link
Owner

@antch thanks for the feedback. I believe the intent was to have display: none in there but for testing or whatever other reason, block had gotten set. I ran through tests in each browser and found no issue with replacing it with display: none and it makes more sense to me to have the div hidden until it's triggered, so I've gone ahead and made that change in the repo. Thanks for the feedback, much appreciated!

@antch
Copy link
Author

antch commented Dec 22, 2014

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants