Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DeprecationWarning from traitlets #51

Closed
NathanDunfield opened this issue Jun 27, 2018 · 3 comments
Closed

DeprecationWarning from traitlets #51

NathanDunfield opened this issue Jun 27, 2018 · 3 comments

Comments

@NathanDunfield
Copy link
Contributor

With DeprecationWarnings on, I get the following warning message with ipympl 0.1.1 and traitlets 4.3.2:

/sage/local/lib/python2.7/site-packages/ipympl/backend_nbagg.py:125: 
DeprecationWarning: metadata {'sync': True} was set from the constructor. 
With traitlets 4.1, metadata should be set using the .tag() method, e.g., 
Int().tag(key1='value1', key2='value2')
  _model_module = Unicode('jupyter-matplotlib', sync=True)

So line 125 (and the subsequent similar code) should be updated to

  _model_module = Unicode('jupyter-matplotlib').tag(sync=True)

The current ipympl requires ipywidgets>=7.0 which in turn requires traitlets>=4.3.1, so there is no need to support traitlets < 4.1.

@SylvainCorlay
Copy link
Member

Thanks @NathanDunfield! Good catch.

Feel free to open a PR. I would be happy to merge.

@NathanDunfield
Copy link
Contributor Author

@SylvainCorlay PR created!

@SylvainCorlay
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants