Remove unused 'close' arg to show(). #466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For reference, _Backend_ipympl.show is effectively the function that pyplot.show calls (pyplot.show even copies the signature of the backend show). In af699c2, a 'close' kwarg was added to _Backend_ipympl.show, although any use of it was immediately removed in a subsequent commit (783419b). Still, this change means that calling e.g. `plt.show(True)`, for example, would no longer set `block=True`, but instead set `close=True`. As the change is relatively recent, it seems better to remove the unused 'close' kwarg again, which also makes the signature consistent with the builtin Matplotlib backends.
|
|
|
Makes sense to me. Thanks for updating here as you go on the main repo :) Only concern is the visual regression test failing. Maybe arestart will help |
|
@ianhi AFAICT the same visual regression test also failed previously with https://github.com/matplotlib/ipympl/actions/runs/2333504817? |
ianhi
approved these changes
Jun 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For reference, _Backend_ipympl.show is effectively the function that
pyplot.show calls (pyplot.show even copies the signature of the backend
show).
In af699c2, a 'close' kwarg was added to _Backend_ipympl.show, although
any use of it was immediately removed in a subsequent commit (783419b).
Still, this change means that calling e.g.
plt.show(True), forexample, would no longer set
block=True, but instead setclose=True.As the change is relatively recent, it seems better to remove the unused
'close' kwarg again, which also makes the signature consistent with the
builtin Matplotlib backends.