Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added meeting calendar under resources #51

Merged
merged 3 commits into from
Jul 5, 2022

Conversation

noatamir
Copy link
Contributor

👋

  1. I added the meeting calendar under resources, highlighting the new contributor meeting.
  2. I wasn't able to preview the CSS locally so please let me know if I added the fa-icon correctly or not.
  3. I also tweaked the text for Gitter to be more inline with what we have in the README on github. Let me know if you'd like me to revert that.
  4. I put those to together. I thought the order made sense because the first 3 are for all project users, and the last 2 are relevant for those interested specifically in contributing to the project.

@QuLogic
Copy link
Member

QuLogic commented Jul 5, 2022

Can you rebase now that #53 is in? Circle doesn't build merges, unfortunately.

@noatamir noatamir force-pushed the add-new-contributor-meeting branch from c0768ae to 4e46c8c Compare July 5, 2022 07:04
@QuLogic
Copy link
Member

QuLogic commented Jul 5, 2022

It looks like the icon is not working?
image

It's FontAwesome v5; I think you might have used a v6 icon name. It probably needs the callout__icon style applied as well.

docs/body.html Outdated Show resolved Hide resolved
Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>
@QuLogic
Copy link
Member

QuLogic commented Jul 5, 2022

Oops, I forgot to put callout__icon in my suggested change.

@noatamir
Copy link
Contributor Author

noatamir commented Jul 5, 2022

I can fix it 😉

docs/body.html Outdated Show resolved Hide resolved
@noatamir
Copy link
Contributor Author

noatamir commented Jul 5, 2022

LGTM now. Thanks for the assist 😃

@noatamir
Copy link
Contributor Author

noatamir commented Jul 5, 2022

(some day we should make all these links open in new tabs right?!)

@jklymak
Copy link
Member

jklymak commented Jul 5, 2022

(some day we should make all these links open in new tabs right?!)

I would be pretty strenuously against that. I don't think we should force users to open tabs, and all browsers have a keyboard shortcuts to open in new tab if the user wishes. The only time it makes sense to open a new tab is if navigating a way will destroy the state of a page, which is definitely not the case for our home page.

@jklymak jklymak merged commit e1b36cb into matplotlib:main Jul 5, 2022
@jklymak
Copy link
Member

jklymak commented Jul 5, 2022

BTW I squash merged this....

@QuLogic QuLogic mentioned this pull request Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants