Add renko chart support #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
DanielGoldfarb
requested changes
Mar 9, 2020
There was a problem hiding this comment.
Awesome! Thank you Caleb. Really nice job implementing Renko charts.
I've added some comments to various places in the code below, where things can be changed to protect the code better, and/or make it cleaner (overall it's fantastic though!). And there is the one issue regarding mav which I am not sure exactly how it should be handled, but I think what we are doing there is not necessarily what a Renko chartist wants to see. All the best. And thank you! --Daniel
|
Thanks for leaving feedback! I'll check it out and let you know what I think later today! |
DanielGoldfarb
requested changes
Mar 12, 2020
|
Thank you so much for the feedback, I really appreciate the comments you left! Let me know if you have any additional fixes/comments! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to create Renko charts by passing in
type='renko'and optionalrenko_paramsdictionary to specifybrick_sizeandatr_lengthto theplot()function. Also includes examples in the README and customization_and_styles.ipynb