Improve parametrized test names in HTML summaries #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"a.b.test_c[x.y]" should give ("a.b", "test_c[x.y]") and not ("a.b.test_c[x", "y]")
The images are path safe but not URL safe. Parametrized tests can include characters such as "\" or "?" in their name which can lead to 404 errors in the HTML summary report.
Cadair
approved these changes
Jun 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bugfix PR which only affects the HTML summaries. The following bugs are fixed:
Fix bug with splitting parametrized test name
"a.b.test_c[x.y]" should give ("a.b", "test_c[x.y]") and not ("a.b.test_c[x", "y]")
urlencode image URLs
The images are path safe but not URL safe. Parametrized tests can include characters such as "" or "?" in their name which can lead to 404 errors in the HTML summary report.