Improve error reporting when test raises an exception #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a bug where, when in hybrid mode, a missing baseline image was not being recorded in the status report. This change makes the code process a baseline download failure similar to how it processes a missing local baseline file.
ConorMacBride
force-pushed
the
missing-remote-baseline
branch
from
61d4eed
to
8a0ec45
Compare
astrofrog
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a test function raises an exception or does not return a figure, the failure is not reported in the HTML summary. This PR makes a fallback result be logged before calling the test function, so it will appear in the HTML summary in case an exception is raised.
This PR also fixes a bug where, when in hybrid mode, a missing baseline image from a remote URL was not being recorded in the status report. This change makes the code process a baseline download failure similar to how it processes a missing local baseline file.