Make parsed arguments accessible to bridges #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tArgs() Signed-off-by: James Hebden <james@ec0.io>
Half-Shot
approved these changes
Jun 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR switches to storing the parsed arguments as an instance variable, so that once parsed, bridges are able to use getArgs() to get access to the parsed arguments for the bridge.
One example use case is retrieving the location of the configuration file, which did not seem possible otherwise, for passing to other libraries which need to read and update the JSON for themselves (example, matrix-puppet-bridge).
Signed-off-by: James Hebden james@ec0.io