Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for alternative registers for metrics #169

Merged
merged 4 commits into from
Jun 25, 2020

Conversation

Half-Shot
Copy link
Contributor

This allows us to provide a alternative register for bridges, for example a threaded register on a different worker thread :). This change also allows bridges to opt out of binding /metrics to the appservice server.

@Half-Shot Half-Shot requested a review from a team June 25, 2020 13:11
Copy link
Contributor

@jaller94 jaller94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@Half-Shot Half-Shot merged commit 111f82f into develop Jun 25, 2020
@jaller94 jaller94 deleted the hs/prom-supply-registry branch June 25, 2020 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants