Typescriptify event queue #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please fix the linting errors first. |
Half-Shot
force-pushed
the
hs/event-queue-finally
branch
from
6138130
to
83b9f8a
Compare
jaller94
approved these changes
Jul 24, 2020
| private queues: { [identifer: string]: { | ||
| events: Array<{ dataReady: DataReady }>; | ||
| consuming: boolean; | ||
| }; } = {}; |
There was a problem hiding this comment.
This line and the two above are allowed to have semicolons??
There was a problem hiding this comment.
Yeah, it's a substitute for a comma. The linter informs me that was the style choice we went for 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fairly easy candidate to port, as it was using ES6 classes already.