Fix uploadContent #279
Merged
Fix uploadContent #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Half-Shot
requested review from
a team and
jaller94
and removed request for
a team
|
hi @benparsons |
| @@ -707,7 +707,7 @@ export class Intent { | |||
| */ | |||
| public async uploadContent(content: Buffer|string|ReadStream, opts: FileUploadOpts = {}): Promise<string> { | |||
| await this.ensureRegistered(); | |||
| return this.client.uploadContent(content, {...opts, onlyContentUri: true}); | |||
| return this.client.uploadContent(content, {...opts, rawResponse: false, onlyContentUri: true}); | |||
There was a problem hiding this comment.
Looks good 👍 Matches API docs https://matrix-org.github.io/matrix-js-sdk/9.1.0/module-base-apis.MatrixBaseApis.html#uploadContent
And ran into this recently in https://gitlab.com/gitterHQ/webapp/-/merge_requests/2042/diffs#note_445605432
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We didn't set this flag, which meant that the raw body was being returned regardless of the other argument.